Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tweaks] Don't run old sidebar width on /following #1731

Merged

Conversation

AprilSylph
Copy link
Member

resolves #1078

@AprilSylph AprilSylph merged commit 3dd5a9f into new-xkit:master Oct 12, 2019
@AprilSylph AprilSylph deleted the fix/old-sidebar-width-following branch October 12, 2019 16:45
motackt pushed a commit to motackt/XKit that referenced this pull request Dec 23, 2020
motackt added a commit to motackt/XKit that referenced this pull request Dec 23, 2020
* [Tweaks] Slim appeal notification icons (new-xkit#1702)

* [Retags] Don't show own tags on rolled-up notes (new-xkit#1703)

* [Tweaks] Slim ask answer notes properly (new-xkit#1616)

* [Read More Now] Use peepr API (new-xkit#1680)

* Update jquery to most recent 3.x version (new-xkit#1704)

* retire jQuery.parseJSON (new-xkit#1705)

* [Read More Now] Remove erroneous init_css (new-xkit#1706)

* Release 7.9.0

* Migrate from $.ajax.error to .fail for 3.0 compat

* Fix explore page post controls (new-xkit#1712)

* [TagViewer] Use fetch, Tag Crawler endpoint (new-xkit#1710)

* Revert "[TagViewer] Use fetch, Tag Crawler endpoint (new-xkit#1710)"

This reverts commit 98b70bd.

* Bump version for revert

* Add option to clear extension data on uninstall (new-xkit#1723)

* [PostBlock] Properly handle post variants (new-xkit#1721)

* warn W Edition users of unofficial copy (new-xkit#1711)

* [One-Click Reply] Fix mentioning (new-xkit#1722)

* [Mass+] Fix search by tag (new-xkit#1724)

* Add line to W Edition warning about its violation of AMO policy

* eslint: indent switch statements

* [Highlighter] Actually check reblogs (new-xkit#1728)

* Better explain W Edition's AMO violation

* [Enhanced Queue] Rewrite shuffle queue (new-xkit#1732)

* [Tweaks] Don't run old sidebar width on /following (new-xkit#1731)

* Pokés Gen 7 (new-xkit#1734)

* Pokés Gen 7

* @ Travis bestow us with your judgement

* @ April bestow us with your judgement

* april appeasal attempt atwo

* [Messaging Tweaks] Added gradient/img support for backgrounds (new-xkit#1736)

* [Enhanced Queue] Don't require refresh after shuffle (new-xkit#1737)

* Added "decrease left padding" option for nested view (new-xkit#1738)

* [Mutual Checker] Update description to reflect messaging API change (new-xkit#1741)

* [Mutual Checker] Add April Fool's day joke (new-xkit#1742)

* [Retags] Hide rollup notes when only viewing retags+responses (new-xkit#1740)

* introduce XKit.svc.post (new-xkit#1701)

* [Soft Refresh] Infinity Update (new-xkit#1683)

* Include XKit version as a header in requests to Tumblr (new-xkit#1744)

* include xkit version as a header

* and in the bridges

* few more places

* version bump

* wrap GM_xmlhttpRequest in patches rather then change the bridge

* bump versions

* fix eslint

* use _.merge

* eslint

* 😔

* Revert "Include XKit version as a header in requests to Tumblr" (new-xkit#1745)

* Revert "Include XKit version as a header in requests to Tumblr (new-xkit#1744)"

This reverts commit 9429587.

* Add code to force_update patches if install is failing.

* bump versions

* Add a 7.9.0 function just in case someone manages to download this patches version without updating xkit

* leave in the code for Nx_XHR

* Nx_XHR: return promise (new-xkit#1743)

* interface.is_following: don't check messaging data (new-xkit#1747)

* Remove tinyMCE poking attempts (new-xkit#1750)

* rewrite Tag Replacer (new-xkit#1749)

* [Read More Now] Don't activate on themes (new-xkit#1753)

* add XKit.interface.mass_edit (new-xkit#1752)

* add XKit.interface.mass_edit

* [Enhanced Queue] Clear queues via mass edit

* [Read More Now] Don't activate in the rich text editor (new-xkit#1754)

* [Tag Replacer] Only replace 1 tag per 5 seconds (new-xkit#1758)

* end the nightmare (new-xkit#1759)

* end the nightmare: part 2 (new-xkit#1761)

* remove some more parseInts

* bump version

* ugh

* fuck eslint for making upgrades too hard

* fix bookmarker test logic

* use post_id_strings in tag replacer and mass+ (new-xkit#1763)

* grab nonces without .getAttribute (new-xkit#1765)

* Revert "grab nonces without .getAttribute" (new-xkit#1766)

* Revert "grab nonces without .getAttribute (new-xkit#1765)"

This reverts commit effd9a1.

* Update xkit_patches.js

* use .nonce if .getAttribute fails (new-xkit#1767)

* support older browsers: switch back to old iteration method (new-xkit#1769)

* use post.id_string (new-xkit#1768)

* [Old Blue] Don't activate on redpop (new-xkit#1771)

* Get the XKit button displaying on redpop (new-xkit#1764)

* add XKit.interface.translate (new-xkit#1773)

* Add Video Downloader (new-xkit#1777)

* [Old Blue] Update for react site (new-xkit#1779)

* one click postage WIP (new-xkit#1776)

* one click postage WIP

* icons!

* wtF

* fix incorrect reblog_type, add react blog_listener

* bump version

* fix quicktags and use_toasts

* remove unused function

* font size

* better font size

* font size v2-final-actual USE THIS ONE.jpg.pdf (1)

* [One-Click Postage] Turn the reblog button green after reblogging (new-xkit#1782)

* Add logic to turn the reblog button green

* Version bump

* [Anti-Capitalism] Hide sponsored posts on react site (new-xkit#1780)

* get memoizedProps more consistently (new-xkit#1784)

* Add async_form_key for kitty requests on redpop (new-xkit#1787)

* add async_form_key for kitty requests

* lint

* cod review!

* simplify, fix regex

* fix the fix

* [One-Click Postage] Update reblog button selector (new-xkit#1788)

* [One-Click Postage] Update reblog button selector

* target using hrefs instead of aria-labels

* [One-Click Postage] Re-add old reblog button selector (new-xkit#1791)

* Make XKit button match color palette (new-xkit#1789)

* [XKit Preferences] Evade Tumblr keyboard shortcuts (new-xkit#1792)

* remove Color Quotes (new-xkit#1797)

* [One-Click Postage] Fix reblog button selector again (new-xkit#1798)

* stop keydown events propagating above XKit windows (new-xkit#1801)

* window.show: remove stray doublequote

* update AccessKit for new dashboard (new-xkit#1803)

* update README (new-xkit#1793)

* [Alternative Timestamps] Hide alt. timestamps when Timestamps is active (new-xkit#1757)

* Updated post listener (new-xkit#1783)

* rewrite Post Limit Checker (new-xkit#1755)

* [XKit Preferences] Remove third-party warnings (new-xkit#1756)

* update Audio Downloader for new dashboard (new-xkit#1805)

* [Audio Downloader] Attach download function directly to buttons (new-xkit#1811)

* I'm looking at this code with reproach

* Address reviewer comments

* interface.kitty.get: retry with new form key upon initial failure (new-xkit#1817)

* Add very basic port of Blacklist to redpop

- Janky css retrieval
- No backwards compatibility
- Fragile code

* Fix use of unnecessary escapes

* Add defaults to keyToCss calls; Return undefined if the css map doesn't contain a key

* Refactor for simplicity; Throw in all the content

* Use async_add_function

* Make review fixes

Simplify css_map loading. Fix parent selector in cases where one key
maps to multiple classes.

* Remove mostly broken hide by default option

* Reinstate original css; Adjust excuse height

* Rename and fix getCssMap caching function

* Css finalFinalAsdf_v2.pleasebegoodonolddash.psd

* Use fancy sibling to work on new dash

* Clean up css and make it pretty

* Fix showing post tags; Remove unnecessary display manipulation

* Version bump!

* Version bump

* Add container to xblacklist_excuse; Insert cloned tags with correct padding

* Fix mini UI on new dash

* Consolidate xkit-button css (no functionality changes)

* Fix font and button coloration on non-default palette

* update Panorama for new dashboard (new-xkit#1819)

* update Open In Tabs for new dashboard (new-xkit#1822)

* update No Recommended for new dashboard (new-xkit#1823)

* [No Recommended] Fix hiding non-recommended posts (new-xkit#1826)

* Attach directly to open_post element

* Fix post searching to handle duplicate ids

* Only run on tumblr pages

* Refuse to process anything within the new post form

* Simplify click listener based on reviewer feedback

* [Blacklist] Show avatar and header on hidden posts (new-xkit#1828)

* update Hide Avatars for new dashboard (new-xkit#1821)

* update Editable Reblogs for new dashboard (new-xkit#1807)

* Release 7.9.2 (new-xkit#1831)

* [One-Click Postage] Turn autocomplete off for tags input (new-xkit#1841)

* [Editable Reblogs] Process all reblog-list-items (new-xkit#1837)

* [Quick Tags] Always activate on redpop (new-xkit#1839)

* [XKit Preferences] SVG Update (new-xkit#1846)

* [No Recommended] Don't target pinned posts by default (new-xkit#1836)

* fix async_add_function exception handling (new-xkit#1849)

* [Timestamps] Update for New Dashboard (new-xkit#1844)

* convert repository to pure WebExtension (new-xkit#1838)

* [Auto Tagger] Don't break OCP on new dash (new-xkit#1852)

* [Blacklist] Allow importing from Tumblr Savior up to v1.1.0 (new-xkit#1853)

* [Timestamps] Check for blog existence in trail (new-xkit#1854)

* [One-Click Postage] Make AlreadyReblogged work on new dash (new-xkit#1856)

* update Audio+ for new dashboard (new-xkit#1829)

* remove Edible Reblogs (new-xkit#1812)

* remove Fresh Prince (new-xkit#1813)

* remove April Fool's (new-xkit#1814)

* remove Bubblr, sharplr (new-xkit#1815)

* update Disable GIFs for new dashboard (new-xkit#1832)

* remove Elevator (new-xkit#1816)

* remove Alternative Timestamps (new-xkit#1857)

* remove Alternative Timestamps

* link to new wiki page in spring cleaning window

* Update prepend target of Header Options

* Fix Go-To-Dash without using sidebar (new-xkit#1867)

* Fix Go-To-Dash without using sidebar

For some reason Go-To-Dash doesn't work properly if the URL doesn't end in a slash. This adds the slash so that Go-To-Dash goes to the correct post.

* I always forget the version bump

* update Classic Search for new dashboard (new-xkit#1833)

* [Vanilla Videos] Update for react site (new-xkit#1786)

* Update read_posts for the new dashboard (new-xkit#1872)

* update read_posts for new dashboard

* don't dim posts in the sidebar

* Revert "remove Fresh Prince" (new-xkit#1860)

* Revert "remove Fresh Prince (new-xkit#1813)"

This reverts commit bd57cf8.

* bug fixes

* log errors for async extensions

* Appease Travis

* version bump; tweak

* fix

* docs

* rest

Co-authored-by: invalidCards <842080+invalidCards@users.noreply.github.com>

* The Great Tweaks Update of July 2020 (new-xkit#1866)

* Add tweak to hide notification badges

* Bonus tweak: hide post highlight (user-requested)

* Address review comments

* Update "Pin Avatars" tweak for React

Avatars should now stay where they belong - at the top of the post.

* Hide Notification -> Badge style dropdown

Allows a bit more flexibility in the user's choice of how the notification buttons should look.

* Add tweak to hide just the activity badge

* Add grayscale option for the new post button

Should:tm: work properly across themes

* Applying nightpool's feedback

Co-authored-by: invalidCards <842080+invalidCards@users.noreply.github.com>

* [Old Blue] Set base font size to 14px (new-xkit#1870)

* Fix floating avatars getting stuck to the post (new-xkit#1876)

* Fix floating avatars getting stuck to the post

I brainfarted and forgot how the :first-child CSS selector worked

* Fix it even better + fix to previous new tweak

Sometimes code is difficult.

* Add Tweak for making the Follow button more subtle (new-xkit#1878)

* stop avatar unsticky tweak from messing up author portraits (new-xkit#1883)

* Always pause the new video element

* Also seek to start of video

* [Old Blue] Add options for old font family & old font size (new-xkit#1882)

* [Satsukimous] Prevent activation as emergency measure (new-xkit#1885)

* [Tweaks] Fix activation on non-react pages (new-xkit#1886)

* Fix satsukimous (new-xkit#1887)

* fix satsukimous

* semi

* [One-Click Postage] Always retain selected blog (new-xkit#1751)

* fix satsukimous..... again (new-xkit#1889)

* fix 2

* bump

* Add Access-Control-Allow-Origin header to local server

* Update xkit build docs

* Fix activity badge still remaining (new-xkit#1880)

* Update tweaks.js

A bit of CSS selector change, a touch of flexibility rewrite, and we should be good to go!

* Apply April patch

Co-authored-by: April Sylph <april@sylph.tech>

* Re-add React check

Missed that when merging my changes apparently...

Co-authored-by: April Sylph <april@sylph.tech>

* Add a patch for XKit.interface.where() for new dashboard (new-xkit#1871)

remove old logic and update for new dashboard

(reviewer note: only fixes XKit.interface.where().dashboard)

* remove Auto Load Images (new-xkit#1901)

* [Blacklist] Allow importing from TS 1.2.0 (new-xkit#1902)

* Fix tweaks to hide radar and recommended blogs (new-xkit#1891)

* Fix tweaks to hide radar and recommended blogs

Due to the nature of the new sidebar, only some inner containers have specific classes, so this is not something that can be easily solved without CSS. Luckily we still have jQuery available and it's a one-liner for both cases.

* Apply feedback

* Older and redder notification badges (new-xkit#1896)

* Older and redder notification badges

Basically the same as the "old red" buttons that were already in there, but now all the red all the time, including in themes like Cybernetic and when using the Old Blue extension

* Apply suggestions from code review

Co-authored-by: April Sylph <april@sylph.tech>

* Apply suggestions from code review

Co-authored-by: April Sylph <april@sylph.tech>

Co-authored-by: April Sylph <april@sylph.tech>

* Fix async logic for xkit_preferences (new-xkit#1775)

* fix preferences button async

* version bump

Co-authored-by: April Sylph <april@sylph.tech>

* [XCloud] Explain local backups, add filesize notes (new-xkit#1855)

* update the rest of the read posts extension for the new dashboard

* Build extension distribution using GitHub Action (new-xkit#1851)

* [Timestamps] Adjust in_search to account for page soft-switching (new-xkit#1904)

* automatically build and sign WebExtension (new-xkit#1850)

* [Reblog Display Options] Bail early if not on dashboard (new-xkit#1915)

* Bail early if not on dashboard

Apparently there have been select cases of posts disappearing from blog themes with RDO on nested mode. I fail to see why RDO should run on blog pages in the first place, so bailing early if we're not on the dashboard should solve this issue.

* Bail early on non-Tumblr pages instead

* [One-Click Postage] Make reblog button greenness more persistent (new-xkit#1908)

* Tweaks: Fix option to hide like animation

* remove Soft Refresh (new-xkit#1910)

* [Go-To-Dash] Update sidebar option to use /blog/view/ (new-xkit#1923)

* [No Recommended] Fix J/K scrolling by not completely hiding posts (new-xkit#1909)

* [Classic Search] Retain tracked tags dropdown (new-xkit#1918)

* Tweaks: Fixes "hide mini follow buttons" for new dash (new-xkit#1926)

* Fixes "hide mini follow buttons" for new dash

* Code style fixes

* Changed method call

* update quick tags for new dashboard. port over needed functions to XKit.interface.react (new-xkit#1894)

Co-authored-by: April Sylph <april@sylph.tech>

* update the classic tags / tag tracking+ extension for the new dashboard (new-xkit#1911)

Co-authored-by: April Sylph <april@sylph.tech>

* [Tag Tracking+] Minor CSS/Functionality Improvements (new-xkit#1942)

* [Anti-Capitalism] Hide sidebar ads and fix j/k (new-xkit#1938)

* [Tweaks] More carefully target notification badges (new-xkit#1937)

Some notification badges are when getting activity on a sideblog, or when receiving a message on an account other than your own (in the blog dropdown of the Messaging pop-up). These badges do not look good when recoloured, which is especially noticable if they are white in colour. The new selectors only target notification badges that are in the header, and not ones that are in descendant drop-downs or those on minified messaging windows.

* Block tumblr's big new Amazon video ad takeover (new-xkit#1943)

Ideally I'd want to block on something more specific then this, but all of the other classes i could use require JS (originally i wanted to do ":not([data-id]) + [data-id]" but CSS has no way to select an element that's followed by another specific element)

* Revert "Block tumblr's big new Amazon video ad takeover" (new-xkit#1944)

* Revert "Block tumblr's big new Amazon video ad takeover (new-xkit#1943)"

This reverts commit 2f9f4df.

* Update anti_capitalism.js

* adjust sponsored selector based on discord chat (new-xkit#1945)

* Fix Go-to-Dash when not using sidebar (new-xkit#1936)

* Fix tag icons not changing colors with theme (new-xkit#1951)

* Use aria label instead of role for React (new-xkit#1958)

When in the "small view", the reblog button loses its `button` role, which makes OCP not pop up unless a modifying key such as Alt or W is being held (since those add it back). Using the translated aria label should provide a more consistent way to make OCP work on the half-screen view.

* Update postblock extension for new dashboard (new-xkit#1900)

* [One-Click Postage] fix on non-react pages (e.g. /liked/by) (new-xkit#1960)

* Fix react control button issues affecting the QuickTags and PostBlock extensions (new-xkit#1962)

* simplify XKit.interface.where() (new-xkit#1903)

* [AccessKit] toggle to disable (some?) XKit animations (new-xkit#1970)

Co-authored-by: April Sylph <april@sylph.tech>

* [Blacklist] Fix ask posts being ignored; don't use 100% cpu (new-xkit#1965)

* [Anti-Capitalism] Prevent hiding content on grid view tagged pages + refinements (new-xkit#1961)

Co-authored-by: beccasafan <beccasafan@gmail.com>

* [Blacklist] Fix soft refresh inconsistency and j/k (new-xkit#1983)

* Debounce post listener (new-xkit#1977)

* debounce post listener

* version bump in case this gets PR'd by itself

* Implement debounce manually + only if no posts

* remove logging

* suggested cleanups from review 👍

Co-Authored-By: nightpool <nightpool@users.noreply.github.com>

Co-authored-by: nightpool <nightpool@users.noreply.github.com>

* Tag Tracking+ fix to handle # coming back from the API (new-xkit#1993)

* [No Recommended] Fully hide recommended posts without breaking J/K scrolling

Not sure why some recommended posts have those non-post spacing elements after them, or if that's the best CSS to match them, but it works on my end at least.

* Update spacer element selector

Co-authored-by: April Sylph <april@sylph.tech>

* Add back visible post indicators as a preference

it's just new-xkit#1929 but without deleting any code

Co-Authored-By: April Sylph <april@sylph.tech>

* reduce hidden post vertical size and refine CSS

mostly copied from my work on show originals for consistency

* change post indicator to show source and add unhide button

again, stolen from my show-originals code

* adjust colors to look good on the sidebar

still stolen from my show-originals, huge surprise

* change indicator text on pinned posts

* increased opacity slightly

since idk, you might actually want to read these things sometimes now

* don't run on explore pages

* add info message about completely hiding posts

* use XKit.interface.hide

* properly used flexbox + removed unnecessary css

* much better use of css class(es)

* reduce variable scope

* refactor collapsing to interface function

* refactor format_date to take timestamps

* backport bottom timestamp location from xkit-rewritten

Co-Authored-By: April Sylph <april@sylph.tech>

* backport minimal timestamp format from xkit-rewritten

Co-Authored-By: April Sylph <april@sylph.tech>

* enable every combination of formats

* refactored format_date for clarity

* stop throwing TypeError

may as well throw this in right? I may not be understanding the error correctly though

Co-Authored-By: April Sylph <april@sylph.tech>

* fix overflow issue + slight vertical misalignment

figuring out working css for this took me like 4 hours haha

* fix destroy()

whoops!

* fix hidden timestamps option with bottom option

* don't set cache if we're not gonna use it

* [TF2] Updated. Look, man, I don't know. Alright? No idea whatsoever.

* [TF2] rewrite just to fix destroy()

sigh.

* New method: parse the HTML

* test code

* Revert "test code"

This reverts commit 68ba6a3.

* Add back the CSS "no data id" method

* oops

* fix mentions not being blacklisted

* handle zero width spaces

* fix "don't block me"

* Revert Timestamps change (new-xkit#1994)

* Update timestamps.js

* Update timestamps.js

* No recommended hotfix: version bump patches

* remove Hermes (new-xkit#1999)

* Autotagger: fix issue where source tag wasn't added (new-xkit#2006)

* [Postblock] Grey icon (new-xkit#1997)

* use GitHub Actions for CI (new-xkit#2009)

* package.json: remove unnecessary fields (new-xkit#2010)

* XKit Preferences: catch extension destroy errors (new-xkit#2008)

* package.json: install and use eslint (new-xkit#2011)

also simplifies .eslintignore

* remove gulp-eslint (new-xkit#2012)

* remove gulp-eslint, gulp lint command

* update build docs

* upgrade to ESLint 4 (new-xkit#2013)

* upgrade to ESLint 4, adjust eslintrc to match codebase

* autofix new errors

* manual fixes

* Old Blue: factor out in-template ternaries

* README: update CI badge (new-xkit#2014)

* upgrade to ESLint 5 (new-xkit#2015)

* upgrade to ESLint 6 (new-xkit#2016)

* upgrade to ESLint 7 (new-xkit#2018)

* One-Click Postage: suggest clearing cookies on error (new-xkit#2020)

Co-authored-by: April Sylph <april@sylph.tech>
Co-authored-by: James Hobin <hobinjk@mit.edu>
Co-authored-by: James Hobin <hobinjk@gmail.com>
Co-authored-by: invalidCards <842080+invalidCards@users.noreply.github.com>
Co-authored-by: RetroAsgardian <oskarsmacaw@gmail.com>
Co-authored-by: cyle gage <cyle@cylesoft.com>
Co-authored-by: nightpool <nightpool@users.noreply.github.com>
Co-authored-by: nightpool <eg1290@gmail.com>
Co-authored-by: Wren <grahamgrasley@gmail.com>
Co-authored-by: beccasafan <beccasafan@gmail.com>
Co-authored-by: xenticore <pearl@bleatbox.net>
Co-authored-by: marcustyphoon <marcustyphoon@gmail.com>
Co-authored-by: Rose Davidson <rose@inklesspen.com>
Co-authored-by: coderpatsy <coderpatsy@users.noreply.github.com>
Co-authored-by: Christine Ye <christineye@users.noreply.github.com>
motackt added a commit to motackt/XKit that referenced this pull request Dec 23, 2020
motackt added a commit to motackt/XKit that referenced this pull request Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New sidebar layout: Ongoing issues
2 participants